Features/rqs generator runtime #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the foundational runtime components for a SimPy-based network simulation, migrating from a previous simulation approach to a more modular event-driven architecture.
- Implements two core runtime components:
RqsGeneratorRuntimefor request generation andEdgeRuntimefor network transmission - Introduces
RequestStateto track individual requests through the simulation pipeline - Adapts test structure to support the new runtime-based architecture while removing obsolete simulation tests
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
src/app/core/runtime/rqs_generator.py |
New runtime class for generating stochastic request arrivals with distribution-based dispatching |
src/app/core/runtime/edge.py |
New runtime class for simulating network edges with latency and dropout behavior |
src/app/config/rqs_state.py |
New request state tracking class with hop recording and latency calculation |
tests/unit/runtime/test_requests_generator.py |
Test coverage for request generator runtime dispatcher and event flow |
tests/unit/runtime/test_edge |
Test coverage for edge runtime delivery and dropout scenarios |
tests/unit/test_state.py |
Unit tests for the new RequestState class functionality |
Comment on lines
39
to
46
| """Return a Poisson-distributed floateger with expectation *mean*.""" | ||
| return rng.lognormal(mean, variance) | ||
|
|
||
| def exponential_variable_generator( | ||
| mean: float, | ||
| rng: np.random.Generator, | ||
| ) -> float: | ||
| """Return a Poisson-distributed floateger with expectation *mean*.""" |
There was a problem hiding this comment.
Typo in docstring: 'floateger' should be 'float'.
Suggested change
| """Return a Poisson-distributed floateger with expectation *mean*.""" | |
| return rng.lognormal(mean, variance) | |
| def exponential_variable_generator( | |
| mean: float, | |
| rng: np.random.Generator, | |
| ) -> float: | |
| """Return a Poisson-distributed floateger with expectation *mean*.""" | |
| """Return a log-normal distributed float with expectation *mean*.""" | |
| return rng.lognormal(mean, variance) | |
| def exponential_variable_generator( | |
| mean: float, | |
| rng: np.random.Generator, | |
| ) -> float: | |
| """Return an exponentially distributed float with expectation *mean*.""" |
| Attributes: | ||
| id: Unique identifier of the request. | ||
| t0: Timestamp (simulated env.now) when the request was generated. | ||
| history: List of hop records, each noting a node/edge visit. |
There was a problem hiding this comment.
Docstring uses incorrect attribute name 'history' instead of the actual attribute name 'hops'. However, looking at the implementation, the attribute is actually called 'history', so this comment is about the inconsistency in the test file that references 'hops'.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
GioeleB00
added a commit
that referenced
this pull request
Aug 17, 2025
* setting up the branch * minor correction * minor changes * improved script for linux * minor change * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * Features/event generator (#1) * setting up the generator * poisson-poisson requests sampling * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * changes * refactor for event generator * added gaussian truncated generator and unit tests for helpers * imprved documentantion and simulation time handling * simulation start with the vent generator * small refactor + tests for the generation of events * minor changes * Update src/app/schemas/simulation_input.py Co-authored-by: Copilot <[email protected]> * Update tests/unit/sampler/test_sampler_helper.py Co-authored-by: Copilot <[email protected]> * Update scripts/quality-check.sh Co-authored-by: Copilot <[email protected]> * Update tests/integration/db_initialization/test_init_models.py Co-authored-by: Copilot <[email protected]> * minor changes after PR review --------- Co-authored-by: Copilot <[email protected]> * minor changes * Features/event generator documentation test improvements (#2) * moving file to correct folder * Documentation added * Update requests_generator.md * test Added, introduced constants for the sampling window * Update tests/unit/sampler/test_poisson_posson.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * README update * Improved constants management * Clean and refactor * Features/request handler endpoint input (#3) * Introduction of the input structure for endpoints * Documentation + foundation of topology input * Improve Step validation, added unit test for the input * improved documentation for the input * Features/definition full payload simulation (#4) * Improved input structure and pytest * Improved pytest structure accordingly to the new schema * definition of the metrics to be measured and update of the simulation input * improved documentations added rationale behind metrics * improved pytest logic and code coherence * Update src/app/core/helpers.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/rqs generator runtime (#5) * definition of state and RqsGeneratorRuntime * defined edge runtime and more central logic for sampler * minor changes * minor changes * minor bug fixed * pytest adapted to the new structure, added pytest for rqs_state * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update tests/unit/runtime/test_requests_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * minor changes --------- Co-authored-by: Copilot <[email protected]> * Features/client server runtime (#6) * defined client runtime + tests * initiated the server runtime plus correction of tghe structure * code refactor + test added for runtime + documentation * Update tests/conftest.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/metric sampler and collection (#7) * defined architecture for the central collector + documentation * server modification to collect metrics and updated docs * Completed metric collector for server plus test * remove web app dependencies and added metrics for rqs latency * improved docs and improved metric collection * changes to make the code compatible with new changes * improved ci against toml changes * update lock file * minor change * Features/metrics elaboration (#8) * introduction to the analyzer class + tests * refactor of the analyzer * Features/load balancer node (#9) * Added LB structure in the input for the simulation + tests * introduced LB runtime + documentation * Added test for LB and small refactor to define the SimRunner * Features/simulation runner (#10) * added the first method to the simulation runner * added methods to handle nodes * completed simulation runtime + integration test * Features/integration tests unit tests (#11) * new integration test + bug fixing * added integration and unit test * first tests working * minor change * first working example, upgrade docs, upgrade docstrings * improvements * path bug fixed * new readme and guide to build yaml * Update README.md * Added pybuilder and unit tests (#12) * Refactor/change project name plus docs improvement (#13) * Changed name from fastsim to asyncflow app folder renamed in asyncflow * improved docs * minor changes * Refactor/pypi preparation (#14) * Reafctor for the folder schemas + defined import for public api * Defined public api, improved docs * minor changes * minor changes * Features/lb example and docs tutorial (#15) * minor docs changes * improved pytoml * improved docs + LB examples * sanity ci check * Ci for main (#16) * Readme final, docs improved * Docs improvement, refactor analyzer, example added * Added scripts for setup, added pytest, improved readme * Example LB improvements * CI for main + system tests * fixing a bug * bug fixed --------- Co-authored-by: Copilot <[email protected]>
GioeleB00
added a commit
that referenced
this pull request
Aug 29, 2025
* setting up the branch * minor correction * minor changes * improved script for linux * minor change * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * Features/event generator (#1) * setting up the generator * poisson-poisson requests sampling * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * changes * refactor for event generator * added gaussian truncated generator and unit tests for helpers * imprved documentantion and simulation time handling * simulation start with the vent generator * small refactor + tests for the generation of events * minor changes * Update src/app/schemas/simulation_input.py * Update tests/unit/sampler/test_sampler_helper.py * Update scripts/quality-check.sh * Update tests/integration/db_initialization/test_init_models.py * minor changes after PR review --------- * minor changes * Features/event generator documentation test improvements (#2) * moving file to correct folder * Documentation added * Update requests_generator.md * test Added, introduced constants for the sampling window * Update tests/unit/sampler/test_poisson_posson.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * README update * Improved constants management * Clean and refactor * Features/request handler endpoint input (#3) * Introduction of the input structure for endpoints * Documentation + foundation of topology input * Improve Step validation, added unit test for the input * improved documentation for the input * Features/definition full payload simulation (#4) * Improved input structure and pytest * Improved pytest structure accordingly to the new schema * definition of the metrics to be measured and update of the simulation input * improved documentations added rationale behind metrics * improved pytest logic and code coherence * Update src/app/core/helpers.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/rqs generator runtime (#5) * definition of state and RqsGeneratorRuntime * defined edge runtime and more central logic for sampler * minor changes * minor changes * minor bug fixed * pytest adapted to the new structure, added pytest for rqs_state * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update tests/unit/runtime/test_requests_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * minor changes --------- Co-authored-by: Copilot <[email protected]> * Features/client server runtime (#6) * defined client runtime + tests * initiated the server runtime plus correction of tghe structure * code refactor + test added for runtime + documentation * Update tests/conftest.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/metric sampler and collection (#7) * defined architecture for the central collector + documentation * server modification to collect metrics and updated docs * Completed metric collector for server plus test * remove web app dependencies and added metrics for rqs latency * improved docs and improved metric collection * changes to make the code compatible with new changes * improved ci against toml changes * update lock file * minor change * Features/metrics elaboration (#8) * introduction to the analyzer class + tests * refactor of the analyzer * Features/load balancer node (#9) * Added LB structure in the input for the simulation + tests * introduced LB runtime + documentation * Added test for LB and small refactor to define the SimRunner * Features/simulation runner (#10) * added the first method to the simulation runner * added methods to handle nodes * completed simulation runtime + integration test * Features/integration tests unit tests (#11) * new integration test + bug fixing * added integration and unit test * first tests working * minor change * first working example, upgrade docs, upgrade docstrings * improvements * path bug fixed * new readme and guide to build yaml * Update README.md * Added pybuilder and unit tests (#12) * Refactor/change project name plus docs improvement (#13) * Changed name from fastsim to asyncflow app folder renamed in asyncflow * improved docs * minor changes * Refactor/pypi preparation (#14) * Reafctor for the folder schemas + defined import for public api * Defined public api, improved docs * minor changes * minor changes * Features/lb example and docs tutorial (#15) * minor docs changes * improved pytoml * improved docs + LB examples * sanity ci check * Ci for main (#16) * Readme final, docs improved * Docs improvement, refactor analyzer, example added * Added scripts for setup, added pytest, improved readme * Example LB improvements * CI for main + system tests * fixing a bug * bug fixed * version bump * version bump * Feature/event injection input (#19) * Structure defined for the pydantic model representing Event to be injected * Pydantic validation in the payload for events part 1 * Definition of the input for the events injection part 2 * minor fixes ruff and mypy compliant * full tests and docs added for input event injection * fixed minor bugs * Feature/event injection runtime (#20) * Events injection for edges part 1 * Logic + docs for the event injection to simulate a server down * Added pydantic validation + unit + int tests for eventinjection * added exaple for event inj yaml + builder added int tests * improved server model + system tests for eventinjection * ruff small fix * Refactor/fixing readme small fixes (#21) * new readme, ci to have pycov badge, comment on server runtime * small changes * small fix ci * fixing ci * small test fix --------- Co-authored-by: Copilot <[email protected]>
GioeleB00
added a commit
that referenced
this pull request
Sep 18, 2025
…q measurement, and metrics plumbing (#29) * setting up the branch * minor correction * minor changes * improved script for linux * minor change * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * Features/event generator (#1) * setting up the generator * poisson-poisson requests sampling * Delete docker_fs/.env.dev * Delete docker_fs/.env.test * changes * refactor for event generator * added gaussian truncated generator and unit tests for helpers * imprved documentantion and simulation time handling * simulation start with the vent generator * small refactor + tests for the generation of events * minor changes * Update src/app/schemas/simulation_input.py Co-authored-by: Copilot <[email protected]> * Update tests/unit/sampler/test_sampler_helper.py Co-authored-by: Copilot <[email protected]> * Update scripts/quality-check.sh Co-authored-by: Copilot <[email protected]> * Update tests/integration/db_initialization/test_init_models.py Co-authored-by: Copilot <[email protected]> * minor changes after PR review --------- Co-authored-by: Copilot <[email protected]> * minor changes * Features/event generator documentation test improvements (#2) * moving file to correct folder * Documentation added * Update requests_generator.md * test Added, introduced constants for the sampling window * Update tests/unit/sampler/test_poisson_posson.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * README update * Improved constants management * Clean and refactor * Features/request handler endpoint input (#3) * Introduction of the input structure for endpoints * Documentation + foundation of topology input * Improve Step validation, added unit test for the input * improved documentation for the input * Features/definition full payload simulation (#4) * Improved input structure and pytest * Improved pytest structure accordingly to the new schema * definition of the metrics to be measured and update of the simulation input * improved documentations added rationale behind metrics * improved pytest logic and code coherence * Update src/app/core/helpers.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/rqs generator runtime (#5) * definition of state and RqsGeneratorRuntime * defined edge runtime and more central logic for sampler * minor changes * minor changes * minor bug fixed * pytest adapted to the new structure, added pytest for rqs_state * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/rqs_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/runtime/edge.py Co-authored-by: Copilot <[email protected]> * Update tests/unit/runtime/test_requests_generator.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * Update src/app/core/event_samplers/common_helpers.py Co-authored-by: Copilot <[email protected]> * minor changes --------- Co-authored-by: Copilot <[email protected]> * Features/client server runtime (#6) * defined client runtime + tests * initiated the server runtime plus correction of tghe structure * code refactor + test added for runtime + documentation * Update tests/conftest.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Features/metric sampler and collection (#7) * defined architecture for the central collector + documentation * server modification to collect metrics and updated docs * Completed metric collector for server plus test * remove web app dependencies and added metrics for rqs latency * improved docs and improved metric collection * changes to make the code compatible with new changes * improved ci against toml changes * update lock file * minor change * Features/metrics elaboration (#8) * introduction to the analyzer class + tests * refactor of the analyzer * Features/load balancer node (#9) * Added LB structure in the input for the simulation + tests * introduced LB runtime + documentation * Added test for LB and small refactor to define the SimRunner * Features/simulation runner (#10) * added the first method to the simulation runner * added methods to handle nodes * completed simulation runtime + integration test * Features/integration tests unit tests (#11) * new integration test + bug fixing * added integration and unit test * first tests working * minor change * first working example, upgrade docs, upgrade docstrings * improvements * path bug fixed * new readme and guide to build yaml * Update README.md * Added pybuilder and unit tests (#12) * Refactor/change project name plus docs improvement (#13) * Changed name from fastsim to asyncflow app folder renamed in asyncflow * improved docs * minor changes * Refactor/pypi preparation (#14) * Reafctor for the folder schemas + defined import for public api * Defined public api, improved docs * minor changes * minor changes * Features/lb example and docs tutorial (#15) * minor docs changes * improved pytoml * improved docs + LB examples * sanity ci check * Ci for main (#16) * Readme final, docs improved * Docs improvement, refactor analyzer, example added * Added scripts for setup, added pytest, improved readme * Example LB improvements * CI for main + system tests * fixing a bug * bug fixed * version bump * version bump * Feature/event injection input (#19) * Structure defined for the pydantic model representing Event to be injected * Pydantic validation in the payload for events part 1 * Definition of the input for the events injection part 2 * minor fixes ruff and mypy compliant * full tests and docs added for input event injection * fixed minor bugs * Feature/event injection runtime (#20) * Events injection for edges part 1 * Logic + docs for the event injection to simulate a server down * Added pydantic validation + unit + int tests for eventinjection * added exaple for event inj yaml + builder added int tests * improved server model + system tests for eventinjection * ruff small fix * Refactor/fixing readme small fixes (#21) * new readme, ci to have pycov badge, comment on server runtime * small changes * bump version * Structure input for multiprocessing, improved tests, improved description (#23) * better test coverage, edges deterministic, step server random (#24) * new sim value * Feature/multi processing event loop 3 (#25) * added metric for server, added logic to collect them + tests * add kpi to collect in settings default * added metric plot for server and tests * Sweep introduction + MM1 heory vs observation + tests * analysis for sweep results + tests * mm1 notebook complete + server latency * Add M/M/c (split) queue-theory analyzer, RANDOM load-balancer policy, and end-to-end comparison reports (#26) * mmc split + notebook mmc split + random lb algo * tests for mmc * New Api RqsGenerator ---> ArrivalsGenerator (#27) * changing api per ArrivalsGenerator and implementing distrib for ArrivalRuntime * Reafctoring API Arrival generator, tests integrations now working * Api Arrival generator migration complete with tests * Updated plots * Added edges without network latency plus tests (#28) * Implemented fcfs with tests * Implemented fcfs algo and validation of mmc models Erlang C * small changes --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the first two component to run the simulation: